Skip to content

License workflow module #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

License workflow module #17

wants to merge 3 commits into from

Conversation

@sonalideepthi777
Copy link

@sonalideepthi777 sonalideepthi777 commented Mar 12, 2025 •
edited
Loading

Description

Manage operations related to Smart Licensing in Cisco Catalyst Center.

Type of Change

  • Bug fix
  • [yes] New feature
  • Breaking change
  • [yes] Documentation update

Checklist

  • [yes] My code follows the style guidelines of this project
  • [yes] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

  • Tasks are idempotent (can be run multiple times without changing state)
  • Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
  • Playbooks are modular and reusable
  • Handlers are used for actions that need to run on change

Documentation

  • All options and parameters are documented clearly.
  • Examples are provided and tested.
  • Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

md-rafeek
md-rafeek reviewed Mar 13, 2025
View reviewed changes
Copy link

@md-rafeek md-rafeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the yaml doc string

plugins/modules/license_workflow_manager.py
dnac_log: "{{dnac_log}}"
state: merged
config:
- smart_account_name: "Solutions Team - IaC for CatC"
Copy link

@md-rafeek md-rafeek Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjust the indentation

plugins/modules/license_workflow_manager.py

self.log("Retrieving the smart account information '{0}'".format(config))

param = {}
Copy link

@md-rafeek md-rafeek Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you passing empty param ?

koderchit
koderchit requested changes Oct 22, 2025
View reviewed changes
plugins/modules/license_workflow_manager.py
Comment on lines +421 to +427
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.cisco.dnac.plugins.module_utils.dnac import (
DnacBase,
validate_list_of_dicts,
)


Copy link

@koderchit koderchit Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validate_list_of_dicts from dnac is outdated. Please make sure to import it from ansible_collections.cisco.dnac.plugins.module_utils.validation and test the workflow one again for all the cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@md-rafeek md-rafeek md-rafeek left review comments

@koderchit koderchit koderchit requested changes

@madhansansel madhansansel Awaiting requested review from madhansansel madhansansel is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sonalideepthi777 @koderchit @md-rafeek @madhansansel